skip line that seems to be a long binary line.#8
Open
Ophtis wants to merge 1 commit intomaxWiklund:masterfrom
Open
skip line that seems to be a long binary line.#8Ophtis wants to merge 1 commit intomaxWiklund:masterfrom
Ophtis wants to merge 1 commit intomaxWiklund:masterfrom
Conversation
Owner
|
Hi @Ophtis Thank you for taking the time to make the pull request! Do you have an example nk file to setup a integration test? Just a few nodes for testing. With kind regards, |
Author
|
Yes, I did a small setup for you to test including the optical flare, you can download it here : (you won't be able to see the result if you don't have the Video Copilot licence btw). Let me know if you need something else ! Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for your tool, its great !
We created this PR because we ran into a performance issue encountered when parsing certain nodes from third-party plugins, such as Optical Flares.
They store extremely large strings that seems to be a precompiled hex, and running regex operations on these values significantly impacts performance.
Since these particular fields are not required for recreating the node graph, this PR proposes skipping them during parsing. (made by @Rogouan )
Here is an exemple of its data (I cropped the string for convinience) :
Thanks !